Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup refactor #687

Merged
merged 52 commits into from
Feb 8, 2024
Merged

Rollup refactor #687

merged 52 commits into from
Feb 8, 2024

Conversation

mateuszaaa
Copy link
Member

@mateuszaaa mateuszaaa commented Feb 6, 2024

  • removed custom serialization
  • removed JSON based serialization
  • using eth compatible types for substrate <-> solidity hash calculation compatibility
  • added test environment and adding unit tests for simplest scenarios
  • added dedicated RPC/runtime api for query pending updates proofs

should be merge after #674

iStrike7 and others added 30 commits November 30, 2023 06:41
@mateuszaaa mateuszaaa added the draft something not ready to be merged label Feb 6, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (71abd93) 48.39% compared to head (fc948e4) 51.36%.

Files Patch % Lines
pallets/rolldown/src/lib.rs 63.82% 51 Missing ⚠️
pallets/rolldown/rpc/src/lib.rs 0.00% 17 Missing ⚠️
node/src/rpc.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           eth-rollup-develop     #687      +/-   ##
======================================================
+ Coverage               48.39%   51.36%   +2.96%     
======================================================
  Files                      42       44       +2     
  Lines                    7397     7307      -90     
======================================================
+ Hits                     3580     3753     +173     
+ Misses                   3817     3554     -263     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mateuszaaa mateuszaaa merged commit e06b4d1 into eth-rollup-develop Feb 8, 2024
49 checks passed
@mateuszaaa mateuszaaa deleted the mat-rolldown-refactor branch February 8, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft something not ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants