Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add eigen chainspec #684

Merged
merged 20 commits into from
Apr 29, 2024
Merged

Conversation

devdanco
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.35%. Comparing base (6e1164f) to head (40ecdcb).
Report is 109 commits behind head on eth-rollup-develop.

❗ Current head 40ecdcb differs from pull request most recent head 0d9b50d. Consider uploading reports for the commit 0d9b50d to get more accurate results

Additional details and impacted files
@@                  Coverage Diff                   @@
##           eth-rollup-develop     #684      +/-   ##
======================================================
- Coverage               52.27%   51.35%   -0.93%     
======================================================
  Files                      44       44              
  Lines                    7573     7308     -265     
======================================================
- Hits                     3959     3753     -206     
+ Misses                   3614     3555      -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mateuszaaa mateuszaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mateuszaaa
Copy link
Member

it was created before we migrated to solochain, so no longer needed

@mateuszaaa mateuszaaa closed this Apr 4, 2024
@mateuszaaa mateuszaaa reopened this Apr 4, 2024
Copy link
Member

@mateuszaaa mateuszaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mateuszaaa mateuszaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should have new chainspec called holesky because in local testnet token addresses will not match

@mateuszaaa mateuszaaa merged commit 95ae80b into eth-rollup-develop Apr 29, 2024
13 of 18 checks passed
@mateuszaaa mateuszaaa deleted the feat/chainspec-eigen branch April 29, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants