Fix max character bug #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyservin
approved these changes
Dec 1, 2024
|
@melizeche did you test what the firmware will do if you have a 13 string stored (from the previous version) and you update to this new version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the captive portal allows you to enter 13 characters for latitude and longitude
This cause a weird bug where only longitude is stored and the POST fails because it doesn't have the latitude value
Also the length for these fields is set to 12
linka-firmware/linka-firmware.ino
Lines 112 to 113 in c21e0f4
In my tests 12 chars was also buggy so 11 is the number, more than enough for our use case(see reference)