Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add carousel jsonld #518

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Add carousel jsonld #518

merged 4 commits into from
Oct 15, 2020

Conversation

statebait
Copy link
Contributor

Description of Change(s):

Implements #415

Adds the carousel jsonld component. Refer here- https://developers.google.com/search/docs/data-types/carousel

The following types are currently supported:

  • Default (the summary list)
  • Course
  • Movie
  • Recipe

Have updated all the e2e cypress tests and the docs in the README

@statebait
Copy link
Contributor Author

@garmeeh

@statebait statebait mentioned this pull request Oct 15, 2020
@garmeeh
Copy link
Owner

garmeeh commented Oct 15, 2020

@all-contributors please add @statebait for code, doc, test

@allcontributors
Copy link
Contributor

@garmeeh

I've put up a pull request to add @statebait! 🎉

Copy link
Owner

@garmeeh garmeeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for adding this feature.

Only comment I would have is that if the jsonld is updated in recipe.tsx it would also have to be updated in carousel.tsx. This s only minor and can be updated in a future refactor.

@garmeeh garmeeh merged commit eb9be46 into garmeeh:master Oct 15, 2020
@statebait statebait deleted the carousel branch October 15, 2020 20:28
@statebait
Copy link
Contributor Author

🎉 Thank you for adding this feature.

Only comment I would have is that if the jsonld is updated in recipe.tsx it would also have to be updated in carousel.tsx. This s only minor and can be updated in a future refactor.

Thanks!! Will make a PR to use a single function to generate the jsonld for recipe (and course).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants