Replace deprecated apt::source parameters #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of apt:source parameters were deprecated, and have now been removed. This commit migrates to replacements * key_source is replaced with passing a hash to the key parameter. * include_src is replaced with passing a hash to the include parameter. * required_packages has been replaced with explicitly installing them, and adding a dependency between the package and the apt::source. I'm not sure if the explicit package installation might cause an issue with other modules doing the same thing.
|
The replacement for required_packages comes from |
|
@garethr any chance to get this merged? |
|
What's the status of this rebase? cc @dpash |
This was referenced Aug 10, 2017
|
Any news about this PR ? |
|
@Jeoffreybauvin You have to tweet to Puppetlabs (see the reaction on my tweet), this may get noticed. Otherwise there's little chance for getting attraction from the maintainers. Or try to open a support request at Puppetlabs? |
cegeka-jenkins
pushed a commit
to cegeka/puppet-docker
that referenced
this pull request
Apr 17, 2024
(maint) don't skip testing "with download location" on most OS's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of apt:source parameters were deprecated, and have now been
removed. This commit migrates to replacements
and adding a dependency between the package and the apt::source.
I'm not sure if the explicit package installation might cause an issue
with other modules doing the same thing.
This will resolve #607