Docker CS source location #461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $package_cs_source_location = 'https://packages.docker.com/1.9/apt/repo' | ||
| $package_cs_key_source = 'https://packages.docker.com/1.9/apt/gpg' | ||
| $package_cs_key = '0xee6d536cf7dc86e2d7d56f59a178ac6c6238f52e' | ||
| unless $package_cs_source_location { |
There was a problem hiding this comment.
You shouldn't need the unless here. These set the defaults, which are then overridden if required in the init.pp.
|
Hi @wazoo. Much appreciated. This currently fails the tests in Travis unfortunately. It would also be useful to add a unit test to verify this functionality and protect it from being broken in the future. I'm happy to help if you need a few pointers. Thanks again. |
|
Thanks for the feedback, I will make those changes and update this when thats done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker CS source version was out of date so I updated that and added the ability to override it so I don't have to create a pull request every time Docker CS is updated. I also added the new params to the docs.