This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Configurable auth and token endpoints #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardner
reviewed
Jul 22, 2021
| @@ -173,7 +175,7 @@ export class AuthService<TIDToken = JWTIDToken> { | |||
| codeChallengeMethod: 'S256' | |||
| } | |||
| // Responds with a 302 redirect | |||
| const url = `${provider}/authorize?${toUrlEncoded(query)}` | |||
| const url = `${authorizeEndpoint || `${provider}/authorize`}?${toUrlEncoded(query)}` | |||
There was a problem hiding this comment.
The backticks look odd here. Are you sure this is right?
`${authorizeEndpoint || `${provider}/authorize`}?${toUrlEncoded(query)}`
gardner
reviewed
Jul 22, 2021
| @@ -10,6 +10,8 @@ export interface AuthServiceProps { | |||
| contentType?: string | |||
| location: Location | |||
| provider: string | |||
| authorizeEndpoint: string | |||
There was a problem hiding this comment.
Would this make them required parameters? That might break existing code out there.
There was a problem hiding this comment.
Yes, you're right. This should be optional to not break existing usages.
|
I'll close this PR since I don't have access to the fork. I'll file a new PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable configuration to use more providers.
Keycloak as an example uses
/authinstead of/authorizeso unfortunately this package does not work out-of-the box.Kind regards.