Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-actions: Remove Ubuntu 22.04 crun workaround #2242

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

mxmxchere
Copy link
Contributor

  • Starting with the GitHub image runner version 20240225.1.0 podman/crun stopped working correctly. Rough summary is that the used kernel and crun 0.17 did not play well together.
  • @fwilhe introduced a workaround by using the binary release of crun 1.14.3
  • The bug was fixed in ubuntu package 0.17+dfsg-1.1ubuntu0.1
  • The workaround is most likely no longer needed. @fwilhe and I tested successfully with the current runner version (20240721.1.0, ubuntu-latest) and without the workaround
  • I also checked that the current runner has crun 0.17+dfsg-1.1ubuntu0.1
  • This PR reverts the workaround so that the crun version that comes with the runner image is used.

actions/runner-images#9425 (comment) (runner bugreport)
https://bugs.launchpad.net/cloud-images/+bug/2056442 (issue at ubuntu)
9f6f9c5 (workaround)
https://launchpad.net/ubuntu/+source/crun/0.17+dfsg-1.1ubuntu0.1 (fixed version)
https://github.com/fwilhe/jubilant-funicular/actions/runs/10197364403/job/28210045524 (@fwilhe 's run)
https://github.com/mxmxchere/gl-action/actions/runs/10196668968/job/28207883622 (my run)
https://github.com/mxmxchere/gl-action/actions/runs/10202473206/job/28226655108#step:2:15 (crun version output)

Copy link
Contributor

@Vincinator Vincinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@Vincinator Vincinator merged commit 54ec1b3 into gardenlinux:main Aug 5, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants