feature: use deb package instead tar.gz for fabricmanager #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhague
reviewed
Nov 18, 2024
| @@ -91,7 +91,7 @@ case $TARGET_ARCH in | |||
| echo "Successfully compiled NVIDIA modules" | |||
| else | |||
| echo "[ERROR] Failed to compile NVIDIA modules" | |||
| cat /tmp/nvidia/NVIDIA-Linux-aarch64-535.86.10/nvidia-installer.log | |||
| cat /tmp/nvidia/NVIDIA-Linux-aarch64-"$DRIVER_VERSION"/nvidia-installer.log | |||
dhague
reviewed
Nov 18, 2024
resources/download_fabricmanager.sh
Outdated
| wget -O /tmp/keyring.deb https://developer.download.nvidia.com/compute/cuda/repos/debian12/x86_64/cuda-keyring_1.1-1_all.deb && dpkg -i /tmp/keyring.deb | ||
| apt-get update | ||
| #apt-get install -V nvidia-open-"$DRIVER_BRANCH" |
There was a problem hiding this comment.
Maybe remove this line instead of commenting out?
There was a problem hiding this comment.
Will be removed.
dhague
reviewed
Nov 18, 2024
| wget -O /tmp/keyring.deb https://developer.download.nvidia.com/compute/cuda/repos/debian12/x86_64/cuda-keyring_1.1-1_all.deb && dpkg -i /tmp/keyring.deb |
There was a problem hiding this comment.
We need to be a bit careful in the future when Garden Linux is based on a Debian version >12. Fine for now though.
There was a problem hiding this comment.
Actually debian12 is the latest one available there. There is debian11, debian10 and ubuntu ones.
dhague
reviewed
Nov 18, 2024
resources/download_fabricmanager.sh
Outdated
| apt-get update | ||
| #apt-get install -V nvidia-open-"$DRIVER_BRANCH" | ||
| apt-get install -V nvidia-fabricmanager-"$DRIVER_BRANCH" nvidia-fabricmanager-dev-"$DRIVER_BRANCH" |
There was a problem hiding this comment.
Is nvidia-fabricmanager-dev needed? I would have expected just nvidia-fabricmanager
There was a problem hiding this comment.
Will be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: