disable kms for workflow builds #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotTheEvilOne
requested changes
Dec 20, 2024
.github/workflows/nightly.yaml
Outdated
| @@ -27,4 +27,4 @@ jobs: | |||
| uses: gardenlinux/gardenlinux/.github/workflows/build.yml@main | |||
| with: | |||
| version: ${{ inputs.version || 'now' }} | |||
| use_kms: ${{ github.event_name != 'workflow_dispatch' || inputs.use_kms }} | |||
| use_kms: ${{ inputs.use_kms }} | |||
There was a problem hiding this comment.
inputs.use_kms is undefined if not executed as a workflow triggered. To get the result expected you may want to use the value ${{ github.event_name == 'workflow_dispatch' && inputs.use_kms || false }}
There was a problem hiding this comment.
will remove this completely since it does not really make sense anyhow... done
NotTheEvilOne
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
LGTM - as documented by GitHub removing input variables from the caller of a workflow is a supported case (see https://docs.github.com/en/enterprise-cloud@latest/actions/writing-workflows/workflow-syntax-for-github-actions#onworkflow_callinputs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cronjobs of of event type
scheduleand hence kms would be enabled.