Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message if feature folder does not contain info.yaml #22

Closed
Vincinator opened this issue Jul 12, 2023 · 2 comments · Fixed by #40
Closed

Better error message if feature folder does not contain info.yaml #22

Vincinator opened this issue Jul 12, 2023 · 2 comments · Fixed by #40
Assignees
Labels
kind/enhancement Enhancement, improvement, extension

Comments

@Vincinator
Copy link
Contributor

Vincinator commented Jul 12, 2023

What would you like to be added:
An error message that tells the developer that the info.yaml is missing for a given feature.

Why is this needed:
Screenshot 2023-07-12 at 16 45 30

@fwilhe thanks for reporting

@Vincinator Vincinator added the kind/enhancement Enhancement, improvement, extension label Jul 12, 2023
@Vincinator Vincinator self-assigned this Jul 12, 2023
@fwilhe
Copy link
Member

fwilhe commented Jul 12, 2023

actually this is the error you get when a feature is missing the info.yaml file:

Screenshot 2023-07-12 at 17 02 05

"dictionary changed size during iteration" is misleading imo because nothing changed at runtime, but the feature without info.yaml is not counted.

the screenshot you posted happened when I actually had a cyclic graph by accident, my suggestion would be that the output should say which feature causes that cycle if possible.

@fwilhe
Copy link
Member

fwilhe commented Oct 18, 2023

Note to self: Got bitten by this again.

Situation: In https://github.com/gardenlinux/ostree-image-builder I have a subset of the gardenlinux repo and wanted to sync my copy with upstream. I don't include all features, and one of the features I removed was the 'sap' feature as it is not needed. But this is declared in the info.yaml of the server feature. This led to the "dictionary changed size during iteration" message.

Vincinator added a commit that referenced this issue Oct 26, 2023
fixes #22

If a feature references a non existing featute,
then the builder should exit with an error message telling
the user that this feature does not exist.
fwilhe pushed a commit that referenced this issue Dec 19, 2023
fixes #22

If a feature references a non existing featute,
then the builder should exit with an error message telling
the user that this feature does not exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants