Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docker] Move DOCFORGE_CONFIG in compose instead of image #242

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[Docker] Move DOCFORGE_CONFIG in compose instead of image #242

merged 1 commit into from
Dec 4, 2024

Conversation

Kostov6
Copy link
Contributor

@Kostov6 Kostov6 commented Dec 4, 2024

What this PR does / why we need it:
This PR moves the setting of the environment variable DOCFORGE_CONFIG to be done from the compose.yaml file to allow supporting the ci/cd scenario

Release note:

NONE

@Kostov6 Kostov6 requested a review from a team as a code owner December 4, 2024 09:11
@Kostov6 Kostov6 changed the title Move DOCFORGE_CONFIG in compose instead of image [ Docker] Move DOCFORGE_CONFIG in compose instead of image Dec 4, 2024
@gardener-robot gardener-robot added the needs/review Needs review label Dec 4, 2024
@Kostov6 Kostov6 changed the title [ Docker] Move DOCFORGE_CONFIG in compose instead of image [Docker] Move DOCFORGE_CONFIG in compose instead of image Dec 4, 2024
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Dec 4, 2024
RadaBDimitrova
RadaBDimitrova approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@RadaBDimitrova RadaBDimitrova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 4, 2024
@RadaBDimitrova RadaBDimitrova merged commit df95814 into gardener:docker Dec 4, 2024
2 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 4, 2024
@Kostov6 Kostov6 mentioned this pull request Dec 3, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RadaBDimitrova RadaBDimitrova RadaBDimitrova approved these changes

Assignees
No one assigned
Labels
reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kostov6 @RadaBDimitrova @gardener-robot