Fix installation of gosec and addlicense
#957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-1
added
reviewed/ok-to-test
thiyyakat
force-pushed
the
bug/fix-install
branch
from
8eb1412 to
7a862bf
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
… in gosec and addlicense installation
thiyyakat
force-pushed
the
bug/fix-install
branch
from
7a862bf to
d4ad98c
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot
added
size/s
gardener-robot-ci-3
added
reviewed/ok-to-test
rishabh-11
force-pushed
the
bug/fix-install
branch
from
ce6167f to
17dd53b
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
thiyyakat
added a commit
to thiyyakat/machine-controller-manager
that referenced
this pull request
Dec 2, 2024
* Change values and names of variables used in tools.mk file to fix bug in gosec and addlicense installation * run make generate * Update go version to v1.23.3 --------- Co-authored-by: Rishabh Patel <[email protected]>
rishabh-11
added a commit
that referenced
this pull request
Dec 2, 2024
* Change values and names of variables used in tools.mk file to fix bug in gosec and addlicense installation * run make generate * Update go version to v1.23.3 --------- Co-authored-by: Rishabh Patel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes the inconsistent variable name used in
tools.mkfor the installation ofaddlicensewhich was preventingadd-license-headermake target from succeeding. Additionally, it also changes the way in whichgosecinstallation is defined intools.mksuch that mcm-providers can leverage it in a consistent manner.The PR also updates the go lang version to
v1.23.3Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: