Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k8s dependencies and adapt FakeObjectTracker #939

Closed
wants to merge 1 commit into from
Closed

Update k8s dependencies and adapt FakeObjectTracker #939

wants to merge 1 commit into from

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Sep 5, 2024 •
edited
Loading

fix tests and linter issues

What this PR does / why we need it:
Update k8s dependencies and adapt FakeObjectTracker to fix linter issue in gardener/gardener PR Upgrade k8s.io/* to v0.31, sigs.k8s.io/controller-runtime to v0.19

Make check command is failing in this gardener PR:

Executing golangci-lint
WARN [runner] Can't run linter goanalysis_metalinter: buildir: failed to load package fakeclient: could not load export data: no export data for "github.com/gardener/machine-controller-manager/pkg/fakeclient"
ERRO Running error: can't run linter goanalysis_metalinter
buildir: failed to load package fakeclient: could not load export data: no export data for "github.com/gardener/machine-controller-manager/pkg/fakeclient"
make: *** [check] Error 3

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Update k8s.io/* dependencies from `v0.29.3` to `v0.31.0`

@MartinWeindel MartinWeindel requested a review from a team as a code owner September 5, 2024 06:56
@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Sep 5, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 5, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 5, 2024
@MartinWeindel
Copy link
Member Author

close in favour of #938

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinWeindel @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot