-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved context with timeout for DrainNode #920
Conversation
74fe3ce
to
9d0e868
Compare
9d0e868
to
9dde1f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Please add a release note, something like below or feel free to come up with a different one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can change the release note to : "Drain timeout is now correctly honored for Pod eviction during Machine Drain" ?
Can you do a test of this with some short timeouts and Pods with large number of PVs to see if there are no surprises ?
Performed the testing, the context cancellation leads to force delete even if pod with PVs are in process of eviction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
This PR introduces a drain Context in
RunDrain
with a timeout so that context cancels and machine can be force deleted later.Which issue(s) this PR fixes:
Fixes #785
Special notes for your reviewer:
Release note: