Keep DesiredReplicas annotation up to date even if no scaling happens
#821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
gardener-robot
added
reviewed/lgtm
Co-authored-by: Himanshu Sharma <[email protected]>
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
This was referenced Jun 5, 2023
himanshu-kun
added a commit
that referenced
this pull request
Jun 5, 2023
… date even if no (#824) * keep desired replicas annotation up to date even if no scaling happens * Update pkg/controller/deployment_sync_test.go Co-authored-by: Himanshu Sharma <[email protected]> --------- Co-authored-by: Himanshu Sharma <[email protected]>
himanshu-kun
added a commit
that referenced
this pull request
Jun 5, 2023
… date even if no (#822) * keep desired replicas annotation up to date even if no scaling happens * Update pkg/controller/deployment_sync_test.go Co-authored-by: Himanshu Sharma <[email protected]> --------- Co-authored-by: Himanshu Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #815
Special notes for your reviewer:
Release note: