Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate logrus from go.mod #289

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Remove duplicate logrus from go.mod #289

merged 1 commit into from
Jul 5, 2019

Conversation

ialidzhikov
Copy link
Member

What this PR does / why we need it:
logrus time ago was renamed from github.com/Sirupsen/logrus to github.com/sirupsen/logrus to be module compatible. However docker/[email protected] was still importing the old github.com/Sirupsen/logrus and this resulted in two different entries in our go.mod for logrus. The PR removes the duplication.

Ref golang/go#28489.

The steps I executed:

# the exact docker/docker rev referenced by k8s.io/apiserver v0.0.0-20181005205051-9f398e330d7f
$ go get github.com/docker/docker@a9fbbdc8dd8794b20af358382ab780559bca589d
$ go get github.com/sirupsen/[email protected]
$ go mod vendor
$ go mod tidy

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@ialidzhikov ialidzhikov requested review from ggaurav10 and a team as code owners July 4, 2019 16:04
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 4, 2019
prashanth26
prashanth26 approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@prashanth26 prashanth26 merged commit 90f1e17 into gardener:master Jul 5, 2019
@ialidzhikov ialidzhikov deleted the enh/remove-duplicate-logrus branch July 5, 2019 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanth26 prashanth26 prashanth26 approved these changes

@ggaurav10 ggaurav10 Awaiting requested review from ggaurav10

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ialidzhikov @prashanth26 @gardener-robot-ci-1