Remove use of defer in printing logs
#87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
|
/invite @himanshu-kun |
himanshu-kun
suggested changes
Mar 28, 2023
pkg/azure/core.go
Outdated
|
|
||
| // Check if provider in the MachineClass is the provider we support | ||
| if req.MachineClass.Provider != ProviderAzure { | ||
| err := fmt.Errorf("requested for Provider '%s', we only support '%s'", req.MachineClass.Provider, ProviderAzure) | ||
| klog.V(2).Infof("Machine creation request failed for %q, Error: %v", req.Machine.Name, err) |
There was a problem hiding this comment.
I don't think this defer statement needs to be removed. as it says processed not successful or similar.
There was a problem hiding this comment.
Should I remove the failed request logs for all the other methods?
There was a problem hiding this comment.
addressed in d5d27b3
pkg/azure/core.go
Outdated
| defer klog.V(2).Infof("Machine deletion request has been processed for %q", req.Machine.Name) | ||
| klog.V(2).Infof("Machine deletion request has been received for %q", req.Machine.Name) |
There was a problem hiding this comment.
addressed in d5d27b3
pkg/azure/core.go
Outdated
Comment on lines
363
to
370
| err := fillUpMachineClass(azureMachineClass, req.MachineClass) | ||
| if err == nil { | ||
| klog.V(2).Infof("MigrateMachineClass request has been processed successfully for %q", req.ClassSpec) | ||
| } else { | ||
| klog.V(2).Infof("MigrateMachineClass request has failed for %q, Error: %v", req.ClassSpec, err) | ||
| } | ||
|
|
||
| return &driver.GenerateMachineClassForMigrationResponse{}, err |
There was a problem hiding this comment.
addressed in d5d27b3
himanshu-kun
added
needs/cherry-pick
|
/needs cherry-pick on rel-v0.10 |
gardener-robot
added
the
needs/cherry-pick
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot
added
the
status/closed
gardener-robot-ci-1
added
the
reviewed/ok-to-test
|
@himanshu-kun Labels needs/on, needs/rel-v0.10 do not exist. |
himanshu-kun
pushed a commit
that referenced
this pull request
Apr 18, 2023
* remove use of defer in printing logs * address review comments * revert log to higher level
himanshu-kun
removed
the
needs/cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR removes the usage of the
deferkeyword when printing logs in some of the methods. Deferred logging leads to confusing logs, as the logged statement is incorrect when the corresponding method has to return an error.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: