Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Gardener credentials data keys #7

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Support Gardener credentials data keys #7

merged 1 commit into from
Nov 30, 2020

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Nov 29, 2020 •
edited
Loading

/area open-source usability
/kind enhancement
/priority normal
/platform azure

What this PR does / why we need it:
All the secret keys used by Gardener are now also allowed as alternatives for this machine-controller-manager plugin. This helps to not make mappings for the data keys.

Special notes for your reviewer:
ℹ️ Similar improvement for in-tree driver: gardener/machine-controller-manager@0e41070 (gardener/machine-controller-manager#578)

Release note:

The machine class secret does now also accept the data keys `clientID`, `clientSecret`, `subscriptionID` and `tenantID` as alternatives for today's keys.

@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure priority/normal needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 29, 2020
@rfranzke rfranzke requested review from AxiomSamarth and prashanth26 and removed request for AxiomSamarth and prashanth26 November 29, 2020 18:00
AxiomSamarth
AxiomSamarth approved these changes Nov 30, 2020
View reviewed changes
Copy link
Collaborator

@AxiomSamarth AxiomSamarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! @rfranzke

AxiomSamarth
AxiomSamarth suggested changes Nov 30, 2020
View reviewed changes
pkg/spi/azure.go Outdated Show resolved Hide resolved
pkg/spi/azure.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Nov 30, 2020
@AxiomSamarth
Copy link
Collaborator

AxiomSamarth commented Nov 30, 2020 •
edited
Loading

I have merged my branch branch-1.0 in master. Could you please rebase this PR with the current master? @rfranzke

@rfranzke
Copy link
Member Author

Btw, go test in the master is broken 👀

@AxiomSamarth
Copy link
Collaborator

Btw, go test in the master is broken 👀

Yes yes, I am currently working on unit test framework for Azure OOT. I am hoping to bring it to good shape by this weekend.

@AxiomSamarth AxiomSamarth merged commit 2d5c464 into master Nov 30, 2020
@rfranzke rfranzke deleted the enh/credentials branch November 30, 2020 07:27
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AxiomSamarth AxiomSamarth AxiomSamarth approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related kind/enhancement Enhancement, improvement, extension needs/changes Needs (more) changes needs/review Needs review platform/azure Microsoft Azure platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rfranzke @AxiomSamarth @gardener-robot