Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract error code from response error #153

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Extract error code from response error #153

merged 1 commit into from
Jun 13, 2024

Conversation

rishabh-11
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #152

Special notes for your reviewer:

Release note:

Error Code is now extracted from azcore.ResponseError.ErrorCode

@rishabh-11 rishabh-11 requested review from a team as code owners June 13, 2024 10:37
@gardener-robot gardener-robot added the needs/review Needs review label Jun 13, 2024
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Jun 13, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 13, 2024
unmarshall
unmarshall approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 13, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 13, 2024
@rishabh-11 rishabh-11 merged commit dcab15a into gardener:master Jun 13, 2024
7 checks passed
@rishabh-11 rishabh-11 deleted the fix-res-exh-error branch June 13, 2024 12:15
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall approved these changes

Assignees

@unmarshall unmarshall

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct extraction of error code from azure ResponseError
5 participants
@rishabh-11 @unmarshall @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot