Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create separate api module #80

Closed
wants to merge 5 commits into from
Closed

Create separate api module #80

wants to merge 5 commits into from

Conversation

mvladev
Copy link

@mvladev mvladev commented Nov 6, 2020

What this PR does / why we need it:

Reduces dependency hell

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

I've split the PR into 3 separate commits to make the review easier.

Release note:

A new module `github.com/gardener/hvpa-controller/api` can be used to get the API definitions.

Switch to `github.com/gardener/hvpa-controller/api` if you vendor only the API of etcd-druid.

@mvladev mvladev requested a review from a team as a code owner November 6, 2020 21:50
@gardener-robot gardener-robot added the needs/review Needs review label Nov 6, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 6, 2020
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 6, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 6, 2020
@mvladev mvladev force-pushed the create-separate-api-module branch from dcdafba to 7869dbc Compare November 6, 2020 22:32
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 6, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 6, 2020
@mvladev mvladev force-pushed the create-separate-api-module branch from 7869dbc to fb2b55f Compare November 7, 2020 07:31
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 7, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 7, 2020
@mvladev mvladev force-pushed the create-separate-api-module branch from fb2b55f to 80586b5 Compare November 7, 2020 07:40
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 7, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 7, 2020
@mvladev mvladev force-pushed the create-separate-api-module branch from 80586b5 to 2ec5c19 Compare November 7, 2020 21:28
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 7, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 7, 2020
@mvladev mvladev force-pushed the create-separate-api-module branch from 2ec5c19 to 07e3f82 Compare November 7, 2020 21:43
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 7, 2020
@mvladev mvladev force-pushed the create-separate-api-module branch from 07e3f82 to 01c84e2 Compare November 7, 2020 21:47
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 7, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 7, 2020
@mvladev mvladev force-pushed the create-separate-api-module branch from 01c84e2 to 69977c1 Compare November 8, 2020 19:19
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 8, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 8, 2020
@mvladev mvladev force-pushed the create-separate-api-module branch from 69977c1 to 58ae620 Compare November 9, 2020 05:20
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 9, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 9, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 9, 2020
@mvladev mvladev force-pushed the create-separate-api-module branch from 573745c to 8fc37dc Compare November 9, 2020 05:28
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 9, 2020
@mvladev mvladev force-pushed the create-separate-api-module branch from 8fc37dc to 3926668 Compare November 9, 2020 05:31
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 9, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 9, 2020
@mvladev mvladev force-pushed the create-separate-api-module branch from 3926668 to 6895e79 Compare November 9, 2020 05:48
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 9, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 9, 2020
@mvladev mvladev mentioned this pull request Nov 9, 2020
Merged
@amshuman-kr amshuman-kr mentioned this pull request Feb 1, 2021
Merged
@amshuman-kr
Copy link
Collaborator

@mvladev Apologies for the delay in processing this PR. There were some conflicts after merging #81. Instead of requesting to rebase/resolve them or trying to force push to #80, I have created #85 where I have basically used the relevant commits from this PR, manually resolved the conflicts where applicable and re-vendored on top to avoid manual conflict resolution for vendored modules.

Can you please take a look at #85? If it looks fine, I will merge #85 and close this PR.

@amshuman-kr
Copy link
Collaborator

Closed via #85 which is just conflict-resolved version of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mvladev @amshuman-kr @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot