Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LeaderElectionID to main #122

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Add LeaderElectionID to main #122

merged 1 commit into from
Apr 19, 2023

Conversation

voelzmo
Copy link
Member

@voelzmo voelzmo commented Apr 6, 2023

What this PR does / why we need it:
Adds a LeaderElectionID to the controller options, allowing to run multiple instances with leader election.

Release note:

Added a LeaderElectionID to the controller options, allowing to run multiple instances of HVPA with leader election when `--leader-elect=true` is passed as commandline arg

@voelzmo voelzmo requested a review from a team as a code owner April 6, 2023 12:31
@voelzmo
Copy link
Member Author

voelzmo commented Apr 6, 2023

/invite @andrerun

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 6, 2023
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Apr 6, 2023
@gardener-robot gardener-robot requested a review from andrerun April 6, 2023 12:31
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 6, 2023
andrerun
andrerun approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@andrerun andrerun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Would HVPA with leader election be any improvement over a single replica HVPA deployment with aggressive liveness policy? HVPA doesn't have much state and should start up quickly and reliably, I think...

@voelzmo
Copy link
Member Author

voelzmo commented Apr 13, 2023

We already run HVPA with multiple replicas: it gets the regular label for controllers and therefore starts up two replicas. We could also decide to fix it the other way around and remove that annotation (similar to what the VPA does), but when it is simple enough to introduce leader election, we probably should do it this way.

@voelzmo voelzmo merged commit 50fb207 into gardener:master Apr 19, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrerun andrerun andrerun approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@voelzmo @andrerun @gardener-robot-ci-3 @gardener-robot