Update everything #111
Merged
Update everything #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because of `runtime.Object does not implement client.Object (missing GetAnnotations method)`
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot
added
size/xl
This was referenced Nov 4, 2022
andrerun
approved these changes
Nov 7, 2022
| @@ -151,8 +151,9 @@ type HvpaControllerRefManager struct { | |||
| // If CanAdopt() returns a non-nil error, all adoptions will fail. | |||
| // | |||
| // NOTE: Once CanAdopt() is called, it will not be called again by the same | |||
| // HvpaControllerRefManager HPA/VPA. Create a new HPA/VPA if it makes | |||
| // sense to check CanAdopt() again (e.g. in a different sync pass). | |||
| // | |||
There was a problem hiding this comment.
The formatter added an unnecessary empty line here and in two more instances below.
There was a problem hiding this comment.
yeah, not sure, all this was basically done automagically
| if err != nil { | ||
| log.Error(err, "Error initializing runtime.Object for", "kind", target.Kind, "name", target.Name, "namespace", hvpa.Namespace) | ||
| return nil | ||
| } | ||
| obj := o.(client.Object) |
There was a problem hiding this comment.
Any idea if it's theoretically possible for the operator to point the targetRef to something which is not a k8s object and have the controller panic upon this type assertion?
There was a problem hiding this comment.
I don't think that actually works given the validations when this resource is applied.
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
k8s.io/api,k8s.io/apimachinery,k8s.io/client-go,k8s.io/controller-runtime,k8s.io/controller-toolsk8s.io/klog/v2and changing how to handleklogrzap,controller-runtimeandginkgocontroller-gen0.9.2Special notes for your reviewer:
Release note: