Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang.org/x/sys #105

Closed
wants to merge 2 commits into from
Closed

Update golang.org/x/sys #105

wants to merge 2 commits into from

Conversation

voelzmo
Copy link
Member

@voelzmo voelzmo commented Sep 9, 2022

What this PR does / why we need it
Updates golang.org/x/sys such that the project builds on MacOS >=12 and golang 1.18 again

Which issue(s) this PR fixes:
Fixes #96
Related upstream bug: golang/go#49219

Special notes for your reviewer:
commands ran

go get -u golang.org/x/sys
go mod vendor

Release note:

Updated golang.org/x/sys such that the project builds on MacOS >=12 and golang 1.18 again

@voelzmo voelzmo requested a review from a team as a code owner September 9, 2022 08:08
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Sep 9, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 9, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 9, 2022
@voelzmo
Copy link
Member Author

voelzmo commented Oct 28, 2022

done in #109

@voelzmo voelzmo closed this Oct 28, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Running tests on MacOS Monterey (12.x) fails
4 participants
@voelzmo @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot