Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cluster-autoscaler Deployment in generic controlplane mutator #6047

Merged

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented May 29, 2022

/area auto-scaling
/kind enhancement

What this PR does / why we need it:
When our forked cluster-autoscaler adopts a version of the upstream cluster-autoscaler that contains kubernetes/autoscaler#4539 (or any of its backports) we have to specify the CSI feature gates for the cluster-autoscaler Deployment. As the CSI feature gates are different for the different cloud providers we have to enhance the generic controlplane mutator and allow provider extensions to mutate the cluster-autoscaler Deployment in order to add the CSI feature gates.

Which issue(s) this PR fixes:
Part of #5064

Release note:

Provider extensions using the generic `controlplane` mutator webhook can now mutate the `cluster-autoscaler` Deployment by implementing the `EnsureClusterAutoscalerDeployment` function. This is required in the context of https://github.com/kubernetes/autoscaler/issues/4517 - cluster-autoscaler supports `--feature-gates` flag and provider extensions have to mutate the cluster-autoscaler Deployment to add the CSI related feature flags to it.

@gardener-prow gardener-prow bot added area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels May 29, 2022
@gardener-prow gardener-prow bot requested review from abdasgupta and timuthy May 29, 2022 14:02
@gardener-prow gardener-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 29, 2022
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented May 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 30, 2022
@gardener-prow gardener-prow bot merged commit f723801 into gardener:master May 30, 2022
@ialidzhikov ialidzhikov deleted the enh/ensure-cluster-autoscaler branch June 26, 2022 16:59
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants