Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical scaling on CPU dropped in VPA resource #318

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

MartinWeindel
Copy link
Member

How to categorize this PR?

/area control-plane
/kind task

What this PR does / why we need it:
Using VPA for sudden CPU spikes while the component is mostly dormant causes needless disruptions and wastes resources twofold: VPA has a minimum slice/resolution of 10m/10M, so it cannot recommend any value below 10m CPU even if this component consumes only 1m on average and 2m in the 95th percentile.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Vertical scaling on CPU dropped in VPA resource

@MartinWeindel MartinWeindel requested review from a team as code owners November 26, 2024 13:55
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/task General task size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 26, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 26, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 26, 2024
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 26, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 26, 2024
@MartinWeindel MartinWeindel merged commit 024b0c7 into master Nov 26, 2024
6 checks passed
@MartinWeindel MartinWeindel deleted the enh/vpa-memory-only branch November 26, 2024 14:55
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Control plane related kind/task General task needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants