Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove minAllowed.cpu for all components #149

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Remove minAllowed.cpu for all components #149

merged 2 commits into from
Mar 2, 2023

Conversation

voelzmo
Copy link
Member

@voelzmo voelzmo commented Mar 1, 2023

How to categorize this PR?

/area auto-scaling
/area os

What this PR does / why we need it:
Remove all minAllowed.cpu values from VPA objects. Our tests didn't show harmful side effects of removing these and in many cases VPA did recommend values lower than the minAllowed. Therefore, we start saving resources if we switch to the VPA recommendation for CPU.

We don't do this for memory, as it is not compressible and would lead to more/faster OOMKills.

Release note:

Removed `minAllowed.cpu` from all VPA objects

@voelzmo voelzmo requested review from a team as code owners March 1, 2023 16:15
@gardener-robot gardener-robot added area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related area/os Operation system related needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 1, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 1, 2023
MartinWeindel
MartinWeindel approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@MartinWeindel MartinWeindel merged commit 7c1f5d0 into gardener:master Mar 2, 2023
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging status/closed Issue is closed (either delivered or triaged) and removed needs/review Needs review labels Mar 2, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related area/os Operation system related needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@voelzmo @MartinWeindel @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot