Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor [email protected] and Upgrade k8s dependencies and controller-runtime #148

Merged
merged 7 commits into from
Mar 1, 2023
Merged

Vendor [email protected] and Upgrade k8s dependencies and controller-runtime #148

merged 7 commits into from
Mar 1, 2023

Conversation

shafeeqes
Copy link
Contributor

How to categorize this PR?

/area open-source
/kind enhancement

What this PR does / why we need it:
Vendor gardener v1.65.0
Upgrade k8s dependencies and controller-runtime

Which issue(s) this PR fixes:

Special notes for your reviewer:

Release note:

The following dependency is updated:
- github.com/gardener/gardener: v1.62.2 -> v1.65.0
- k8s.io/* : v0.26.0 -> v0.26.1
- sigs.k8s.io/controller-runtime: v0.13.1-> v0.14.4

shafeeqes added 6 commits March 1, 2023 11:46
@shafeeqes
Vendor [email protected]
5aab951 
Upgrade `k8s.io/*` dependencies to `v0.26.1`
Upgrade `controller-runtime` dependencies to `v0.14.4`
@shafeeqes
Set job name for prometheus
438bb81 
See https://github.com/gardener/gardener/blob/master/docs/monitoring/README.md#seed-prometheus and https://github.com/shafeeqes/gardener/blob/31c7d023066bffaa4cc9dcdc2b3a614ee2c43740/charts/seed-bootstrap/charts/monitoring/templates/config.yaml#L33-L39
@shafeeqes
Adapt imagevector.Read function
659506f
@shafeeqes
Run make format
dfb71de 
Now we have a linter for grouping imports.
Also run `make format` at the end of `make generate`.
@shafeeqes
Run make generate
6c666e5
@shafeeqes
Remove MR health check for ShootSystemComponentsHealthy condition
a1a1a30 
Gardener now checks all the ManagedResources in the shoot controlplane which does not specify `spec.class`, so these MRs are already covered.
@shafeeqes shafeeqes requested review from a team as code owners March 1, 2023 06:25
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) labels Mar 1, 2023
@shafeeqes shafeeqes mentioned this pull request Mar 1, 2023
Closed
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 1, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 1, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 1, 2023
MartinWeindel
MartinWeindel approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Mar 1, 2023
@MartinWeindel MartinWeindel merged commit 940962e into gardener:master Mar 1, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 1, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 1, 2023
@MartinWeindel MartinWeindel mentioned this pull request Mar 1, 2023
Closed
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 1, 2023
@shafeeqes shafeeqes mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shafeeqes @MartinWeindel @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot