Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt high-availability configuration #138

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Adapt high-availability configuration #138

merged 3 commits into from
Nov 22, 2022

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Nov 21, 2022

How to categorize this PR?

/area high-availability
/kind enhancement

What this PR does / why we need it:
This PR prepares components for HA by labeling them with the corresponding high-availability-config.resources.gardener.cloud/type and defining the required PodDisruptionBudget, please see this document for more information.

Which issue(s) this PR fixes:
Part of gardener/gardener#6529

Release note:

Extension and control-plane components have been adjusted to the high availability configuration supported by Gardener as of release `v1.60`. See [this document](https://github.com/gardener/gardener/blob/master/docs/development/high-availability.md) for more information about HA in gardener.
This release adds HA support for the service's control-plane components when extension is deployed along with Gardener >= `v1.60`. Please see [this document](https://github.com/gardener/gardener/blob/master/docs/usage/shoot_high_availability.md) for more information about HA settings in shoot clusters.

@timuthy timuthy requested review from a team as code owners November 21, 2022 14:57
@gardener-robot gardener-robot added area/high-availability High availability related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 21, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2022
@timuthy timuthy mentioned this pull request Nov 21, 2022
Closed
56 tasks
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 21, 2022
@timuthy timuthy force-pushed the enhancement.ha-config branch from 9b9fb6c to aa17d5d Compare November 22, 2022 09:32
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 22, 2022
MartinWeindel
MartinWeindel previously approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

example/controller-registration.yaml Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 22, 2022
@gardener-robot gardener-robot added needs/review Needs review and removed needs/review Needs review labels Nov 22, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 22, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 22, 2022
MartinWeindel
MartinWeindel reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if the suggested change is your intention?

charts/internal/shoot-cert-management-seed/templates/poddisruptionbudget.yaml Outdated Show resolved Hide resolved
@timuthy timuthy force-pushed the enhancement.ha-config branch from ae94786 to bc2efcb Compare November 22, 2022 16:07
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 22, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 22, 2022
MartinWeindel
MartinWeindel reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next try to fix the controller-registration.yaml

example/controller-registration.yaml Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 22, 2022
MartinWeindel
MartinWeindel approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@MartinWeindel MartinWeindel merged commit 6d6375d into gardener:master Nov 22, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 22, 2022
@timuthy timuthy deleted the enhancement.ha-config branch November 22, 2022 19:18
@timuthy
Copy link
Member Author

timuthy commented Nov 22, 2022

Thanks @MartinWeindel

MartinWeindel added a commit that referenced this pull request Sep 1, 2023
@MartinWeindel
add release notes
dbff065 
**Release Notes**:
```bugfix user github.com/gardener/cert-management #140 @MartinWeindel
Disable followCNAME by default again as it was activated implicitly by github.com/go-acme/lego version upgrade
```
```bugfix operator github.com/gardener/cert-management #138 @MartinWeindel
Fix edge case of inconsistent certificate/secret: request certificate in this case.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
area/high-availability High availability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@timuthy @MartinWeindel @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot