Make the cache size field immutable #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
gardener-prow
bot
added
do-not-merge/work-in-progress
gardener-prow
bot
added
cla: yes
96 tasks
ialidzhikov
force-pushed
the
enh/immutable-cache-size
branch
from
658c5ea to
29c6514
Compare
gardener-prow
bot
added
size/L
gardener-prow
bot
removed
the
do-not-merge/work-in-progress
ialidzhikov
force-pushed
the
enh/immutable-cache-size
branch
from
29c6514 to
edff842
Compare
|
/test pull-gardener-extension-registry-cache-e2e-kind |
|
/assign |
Currently we are using StatefulSet volumeClaimTemplate to provision the PVC. However the corresponding StatefulSet field that controls the PVC size is immutable. It is not possible to resize/enlarge the underlying PVC through the StatefulSet spec. See kubernetes/enhancements#661 This commit makes the cache size field immutable until we decide how to implement the resize.
ialidzhikov
force-pushed
the
enh/immutable-cache-size
branch
3 times, most recently
from
7eb9911 to
78c4191
Compare
ialidzhikov
force-pushed
the
enh/immutable-cache-size
branch
from
78c4191 to
abe4c17
Compare
|
LGTM label has been added. Git tree hash: 9e2a4391ec3cc797d884016a495eda7708c90c02
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dimitar-kostadinov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
Currently we are using StatefulSet volumeClaimTemplate to provision the PVC. However the corresponding StatefulSet field that controls the PVC size is immutable. It is not possible to resize/enlarge the underlying PVC through the StatefulSet spec. See kubernetes/enhancements#661 This commit makes the cache size field immutable until we decide how to implement the resize.
GRM currently does not try to update the
volumeClaimTemplatesof a StatefulSet as the field is immutable. See https://github.com/gardener/gardener/blob/292970d299b4a5b113c148fc23488b11542c8dd5/pkg/resourcemanager/controller/managedresource/merger.go#L284-L287. Hence, updating the cache's size via the Shoot spec gives the impression that the update went through and was successful but actually the update does not happen at all.Which issue(s) this PR fixes:
Part of #3
Special notes for your reviewer:
N/A
Release note: