Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CloudProfile MachineImages validation #932

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

hebelsan
Copy link
Contributor

How to categorize this PR?

/area quality
/kind enhancement
/platform gcp

What this PR does / why we need it:
This PR adjusts the cloudProfile validation so that all images in cloudProfile map to a valid image in the cloudProfileConfig.
Follow up to gardener/gardener-extension-provider-azure#1020.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Validate that all images in cloudProfile map to a valid image in the cloudProfileConfig 

@hebelsan hebelsan requested review from a team as code owners December 20, 2024 13:03
@gardener-robot gardener-robot added needs/review Needs review area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Dec 20, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 20, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 20, 2024
@hebelsan hebelsan changed the title Fix cloud profile validation Fix XloudProfile MachineImages validation Dec 23, 2024
@hebelsan hebelsan changed the title Fix XloudProfile MachineImages validation Fix CloudProfile MachineImages validation Dec 23, 2024
Copy link
Member

@LucaBernstein LucaBernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 27, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 27, 2024
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo kon-angelo merged commit 3fe9f2a into gardener:master Jan 13, 2025
19 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants