Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose egressCIDRs in provider status #752

Merged
merged 6 commits into from
May 8, 2024
Merged

Expose egressCIDRs in provider status #752

merged 6 commits into from
May 8, 2024

Conversation

hebelsan
Copy link
Contributor

@hebelsan hebelsan commented May 3, 2024

How to categorize this PR?

/area networking
/kind enhancement
/platform gcp

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

provider-gcp will calculate a shoot's Egress CIDRs on infrastructure reconciliation

@hebelsan hebelsan requested review from a team as code owners May 3, 2024 07:54
@gardener-robot gardener-robot added needs/review Needs review area/networking Networking related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 3, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 3, 2024
@hebelsan
Copy link
Contributor Author

hebelsan commented May 3, 2024

/test

@testmachinery
Copy link

testmachinery bot commented May 3, 2024 •
edited
Loading

Testrun: e2e-9jdfz
Workflow: e2e-9jdfz-wf
Phase: Failed

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| bastion-test        | bastion-test        | Succeeded | 7m46s    |
| infrastructure-test | infrastructure-test | Failed    | 7m59s    |
| infrastructure-test | infra-flow-test     | Omitted   | 0s       |
| infrastructure-test | infra-migrate-test  | Omitted   | 0s       |
+---------------------+---------------------+-----------+----------+

kon-angelo
kon-angelo previously approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 3, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 3, 2024
@kon-angelo kon-angelo self-requested a review May 3, 2024 09:03
@gardener-robot gardener-robot added needs/review Needs review and removed needs/review Needs review labels May 3, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 3, 2024
@hebelsan
Copy link
Contributor Author

hebelsan commented May 3, 2024

/test

@testmachinery
Copy link

testmachinery bot commented May 3, 2024 •
edited
Loading

Testrun: e2e-mjnz4
Workflow: e2e-mjnz4-wf
Phase: Failed

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| bastion-test        | bastion-test        | Succeeded | 7m55s    |
| infrastructure-test | infrastructure-test | Succeeded | 8m5s     |
| infrastructure-test | infra-flow-test     | Failed    | 2m49s    |
| infrastructure-test | infra-migrate-test  | Omitted   | 0s       |
+---------------------+---------------------+-----------+----------+

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 3, 2024
@hebelsan
Copy link
Contributor Author

hebelsan commented May 3, 2024

/test

@testmachinery
Copy link

testmachinery bot commented May 3, 2024 •
edited
Loading

Testrun: e2e-b26dx
Workflow: e2e-b26dx-wf
Phase: Failed

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| bastion-test        | bastion-test        | Succeeded | 7m41s    |
| infrastructure-test | infrastructure-test | Succeeded | 8m26s    |
| infrastructure-test | infra-flow-test     | Failed    | 8m46s    |
| infrastructure-test | infra-migrate-test  | Omitted   | 0s       |
+---------------------+---------------------+-----------+----------+

@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 6, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 6, 2024
@hebelsan
Copy link
Contributor Author

hebelsan commented May 6, 2024

/test

@testmachinery
Copy link

testmachinery bot commented May 6, 2024 •
edited
Loading

Testrun: e2e-f2lkn
Workflow: e2e-f2lkn-wf
Phase: Failed

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| bastion-test        | bastion-test        | Succeeded | 7m33s    |
| infrastructure-test | infrastructure-test | Succeeded | 7m51s    |
| infrastructure-test | infra-flow-test     | Succeeded | 8m25s    |
| infrastructure-test | infra-migrate-test  | Failed    | 8m50s    |
+---------------------+---------------------+-----------+----------+

@hebelsan
Copy link
Contributor Author

hebelsan commented May 6, 2024

/test

@testmachinery
Copy link

testmachinery bot commented May 6, 2024 •
edited
Loading

Testrun: e2e-xzm7l
Workflow: e2e-xzm7l-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| bastion-test        | bastion-test        | Succeeded | 7m58s    |
| infrastructure-test | infra-migrate-test  | Succeeded | 8m39s    |
| infrastructure-test | infrastructure-test | Succeeded | 7m40s    |
| infrastructure-test | infra-flow-test     | Succeeded | 8m28s    |
+---------------------+---------------------+-----------+----------+

kon-angelo
kon-angelo approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo kon-angelo merged commit cd20026 into gardener:master May 8, 2024
12 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 8, 2024
@kon-angelo kon-angelo added the area/ipcei IPCEI (Important Project of Common European Interest) label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hebelsan @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot