Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix csi-volume-modifier deployment after update to v0.1.3 #870

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Fix csi-volume-modifier deployment after update to v0.1.3 #870

merged 2 commits into from
Jan 26, 2024

Conversation

vpnachev
Copy link
Member

How to categorize this PR?

/area control-plane
/kind bug
/platform aws

What this PR does / why we need it:
Adapt aws-csi-volume-modifier container in the csi-driver-controller deployment after the update to v0.1.3 (ref: #855) as it is described in awslabs/volume-modifier-for-k8s#14

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
No release notes as the update to v0.1.3 has not been released.

Release note:

NONE

@vpnachev vpnachev requested review from a team as code owners January 26, 2024 13:04
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/bug Bug platform/aws Amazon web services platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 26, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 26, 2024
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Jan 26, 2024
@vpnachev vpnachev requested a review from kon-angelo January 26, 2024 13:59
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 26, 2024
@kon-angelo kon-angelo mentioned this pull request Jan 26, 2024
Closed
kon-angelo
kon-angelo approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Jan 26, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 26, 2024
@kon-angelo kon-angelo merged commit 63677ab into gardener:master Jan 26, 2024
13 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 26, 2024
@vpnachev vpnachev deleted the fix/csi-volume-modifier-deployment branch January 26, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vpnachev @kon-angelo @gardener-robot-ci-1 @gardener-robot