Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.25] Automated cherry pick of #365: Setting CSI AWS topology label on machine deployment creation to allow scale-up #368

Conversation

himanshu-kun
Copy link
Contributor

/area/auto-scaling
/kind/enhancement

Cherry pick of #365 on release-v1.25.

#365: Setting CSI AWS topology label on machine deployment creation to allow scale-up

Release Notes:

AWS CSI driver specific topology label "topology.ebs.csi.aws.com/zone" is set as a label on machine deployments to allow the proper working of cluster-autoscaler during scale-up. 

himanshu-kun and others added 7 commits June 29, 2021 12:44
Co-authored-by: Prashanth <[email protected]>

Co-authored-by: Prashanth <[email protected]>

Co-authored-by: Prashanth <[email protected]>
not exporting csi driver key constant

Co-authored-by: Vladimir Nachev <[email protected]>
…pdated constant name to `awsCSIDriverTopologyKey`
moved comments

Co-authored-by: Vladimir Nachev <[email protected]>
@himanshu-kun himanshu-kun requested review from a team as code owners June 29, 2021 07:14
@gardener-robot gardener-robot added needs/review Needs review area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/enhancement Enhancement, improvement, extension size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jun 29, 2021
@gardener-robot-ci-2
Copy link
Contributor

Thank you @himanshu-kun for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test
/squash

@gardener-robot gardener-robot added merge/squash Should be merged via 'Squash and merge' reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/review Needs review labels Jun 29, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 29, 2021
Copy link

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 25f35e3 into gardener:release-v1.25 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants