Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable dual stack #677

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Enable dual stack #677

wants to merge 21 commits into from

Conversation

kevin-lacoo
Copy link
Contributor

@kevin-lacoo kevin-lacoo commented Dec 21, 2023 •
edited
Loading

How to categorize this PR?

/area networking
/kind enhancement
/platform alicloud

What this PR does / why we need it:
This PR adds the spec.provider.infrastructureConfig.dualStack.enabled field which specifies whether dualstack or IPv4-only should be supported by the infrastructure. When the flag is set to true an Alicloud provided IPv6 CIDR block will be attached to the VPC. And two extra vswitches with IPv6 CIDR and one ipv6Gateway will be created in the VPC.

This field can be set in the shoot spec and has false as default.

spec:
  provider:
    infrastructureConfig:
      dualStack:
          enabled: true

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Infrastructure dualstack support can be enabled via `spec.provider.infrastructureConfig.dualStack.enabled: true` in the shoot.yaml.

@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension platform/alicloud Alicloud platform/infrastructure needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Dec 21, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 21, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 27, 2023
@kevin-lacoo
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Dec 28, 2023 •
edited
Loading

Testrun: e2e-rs2pm
Workflow: e2e-rs2pm-wf
Phase: Failed

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Failed    | 25m19s   |
| bastion-test        | bastion-test        | Succeeded | 9m55s    |
+---------------------+---------------------+-----------+----------+

@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 28, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 29, 2023
@kevin-lacoo
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Jan 8, 2024 •
edited
Loading

Testrun: e2e-gnbts
Workflow: e2e-gnbts-wf
Phase: Failed

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Failed    | 24m30s   |
| bastion-test        | bastion-test        | Succeeded | 9m56s    |
+---------------------+---------------------+-----------+----------+

@kevin-lacoo
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Jan 9, 2024 •
edited
Loading

Testrun: e2e-kr58m
Workflow: e2e-kr58m-wf
Phase: Failed

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| bastion-test        | bastion-test        | Succeeded | 9m37s    |
| infrastructure-test | infrastructure-test | Failed    | 24m22s   |
+---------------------+---------------------+-----------+----------+

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 9, 2024
@kevin-lacoo
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Jan 10, 2024 •
edited
Loading

Testrun: e2e-vpvkv
Workflow: e2e-vpvkv-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 29m16s   |
| bastion-test        | bastion-test        | Succeeded | 9m52s    |
+---------------------+---------------------+-----------+----------+

@gardener-robot gardener-robot added needs/review Needs review needs/second-opinion Needs second review by someone else and removed needs/review Needs review reviewed/lgtm Has approval for merging labels Apr 22, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 22, 2024
@kevin-lacoo
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Apr 22, 2024 •
edited
Loading

Testrun: e2e-zlk4r
Workflow: e2e-zlk4r-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 22m27s   |
| bastion-test        | bastion-test        | Succeeded | 7m1s     |
+---------------------+---------------------+-----------+----------+

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 22, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/control-plane Control plane related area/networking Networking related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else platform/alicloud Alicloud platform/infrastructure size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kevin-lacoo @gardener-robot @ScheererJ @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3