Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support node local dns feature #92

Merged
merged 8 commits into from
Jun 22, 2022
Merged

Support node local dns feature #92

merged 8 commits into from
Jun 22, 2022

Conversation

DockToFuture
Copy link
Member

@DockToFuture DockToFuture commented May 17, 2022 •
edited
Loading

How to categorize this PR?

/area networking
/kind enhancement

What this PR does / why we need it:
With this PR it is possible to run gardener cilium clusters with node local dns cache.

Requires gardener/gardener#6144 to work properly.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Support node local dns cache on gardener cilium clusters.

@gardener-robot gardener-robot added area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels May 17, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 17, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 17, 2022
@DockToFuture DockToFuture force-pushed the support/node-local-dns-feature branch from 4e28ed4 to 4f393f6 Compare May 17, 2022 15:07
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 17, 2022
@DockToFuture DockToFuture force-pushed the support/node-local-dns-feature branch from 4f393f6 to 2703b01 Compare May 18, 2022 09:32
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 18, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 18, 2022
@DockToFuture DockToFuture force-pushed the support/node-local-dns-feature branch from 2703b01 to 236f7c8 Compare May 18, 2022 09:55
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 18, 2022
@DockToFuture DockToFuture force-pushed the support/node-local-dns-feature branch from 236f7c8 to 5f4afa8 Compare May 18, 2022 11:57
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 18, 2022
@DockToFuture DockToFuture marked this pull request as ready for review May 18, 2022 12:01
@DockToFuture DockToFuture requested review from a team as code owners May 18, 2022 12:01
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label May 25, 2022
@DockToFuture DockToFuture force-pushed the support/node-local-dns-feature branch from 5f4afa8 to 4bef331 Compare May 26, 2022 10:13
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 26, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 26, 2022
@DockToFuture DockToFuture force-pushed the support/node-local-dns-feature branch from 4bef331 to 649781e Compare May 27, 2022 09:28
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 15, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 15, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 15, 2022
@DockToFuture DockToFuture force-pushed the support/node-local-dns-feature branch from ebb7320 to a2a4b25 Compare June 15, 2022 11:13
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) and removed size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Jun 15, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 15, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 15, 2022
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) and removed size/l Size of pull request is large (see gardener-robot robot/bots/size.py) labels Jun 15, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 15, 2022
@DockToFuture DockToFuture mentioned this pull request Jun 20, 2022
Merged
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 20, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 20, 2022
ScheererJ
ScheererJ approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

How do we address the race between the node local dns rollout and the web hook registration?

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Jun 22, 2022
@DockToFuture
Copy link
Member Author

/lgtm

How do we address the race between the node local dns rollout and the web hook registration?

gardener/gardener#6144 solves this race however we need a new gardener release version in order to work or need to backport the change.

@DockToFuture DockToFuture merged commit 4285c22 into gardener:master Jun 22, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 22, 2022
@DockToFuture DockToFuture deleted the support/node-local-dns-feature branch June 22, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@DockToFuture @rfranzke @ScheererJ @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot