Switch GCR -> Artifact-Registry #231

ccwienk · 2023-11-30T19:41:28Z

GCR has been deprecated [0] in favour of Artifact-Registry.

Thus, change push-targets for OCI-Images:

europe-docker.pkg.dev/gardener-project/snapshots for snapshots
europe-docker.pkg.dev/gardener-project/releases for releases

To allow users for smooth transitioning, keep also publishing to GCR.

[0]
https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr

Release note:

Change OCI Image Registry from GCR (`eu.gcr.io/gardener-project`) to Artifact-Registry (`europe-docker.pkg.dev/gardener-project/releases`). Users should update their references.

ccwienk · 2023-11-30T20:08:28Z

/test pull-extension-networking-cilium-e2e-kind

ccwienk · 2023-11-30T20:44:09Z

/test pull-extension-networking-cilium-e2e-kind

ccwienk · 2023-11-30T22:27:48Z

/test pull-extension-networking-cilium-e2e-kind

ccwienk · 2023-12-01T08:05:44Z

/test pull-extension-networking-cilium-e2e-kind

.ci/pipeline_definitions

test/templates/network-connectivity-test.yaml.tpl

DockToFuture · 2023-12-01T09:58:01Z

.ci/pipeline_definitions

@@ -18,8 +19,9 @@ gardener-extension-networking-cilium:
      publish:
        dockerimages:
          gardener-extension-networking-cilium:
-            registry: 'gcr-readwrite'


Is the registry field now obsolete?

@DockToFuture : in a way, yes. we calculate the appropriate credentials based on metadata we keep together w/ the credentials. it is of course still supported to explicitly overwrite the automatic credentials-selection. however, I think it is better to not do so and thus not hard-code cfg names in our pipeline-definitions

hack/test-e2e-provider-local.sh

Makefile

DockToFuture · 2023-12-05T11:53:00Z

Makefile

@@ -15,7 +15,7 @@
 EXTENSION_PREFIX            := gardener-extension
 NAME                        := networking-cilium
 ADMISSION_NAME              := admission-cilium
-REGISTRY                    := eu.gcr.io/gardener-project/gardener
+REGISTRY                    := europe-docker.pkg.dev/gardener-project/releases


Should be the public path I guess.

.ci/pipeline_definitions

GCR has been deprecated [0] in favour of Artifact-Registry. Thus, change push-targets for OCI-Images: - europe-docker.pkg.dev/gardener-project/snapshots for snapshots - europe-docker.pkg.dev/gardener-project/releases for releases To allow users for smooth transitioning, keep also publishing to GCR. [0] https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr

ScheererJ

Thanks for the changes.

/lgtm

.ci/pipeline_definitions

cleanup: remove obsolete/optional attributes

b071581

ccwienk requested review from a team as code owners November 30, 2023 19:41

gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 30, 2023

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 30, 2023

ccwienk requested review from DockToFuture and ScheererJ November 30, 2023 19:42

gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 30, 2023

ccwienk force-pushed the gcr-to-ar branch from c375eb2 to b7fab1b Compare December 1, 2023 08:50

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 1, 2023

ccwienk force-pushed the gcr-to-ar branch from b7fab1b to 8327985 Compare December 1, 2023 08:51

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 1, 2023

ScheererJ reviewed Dec 1, 2023

View reviewed changes

.ci/pipeline_definitions Outdated Show resolved Hide resolved

.ci/pipeline_definitions Show resolved Hide resolved

.ci/pipeline_definitions Show resolved Hide resolved

test/templates/network-connectivity-test.yaml.tpl Show resolved Hide resolved

DockToFuture reviewed Dec 1, 2023

View reviewed changes

DockToFuture reviewed Dec 5, 2023

View reviewed changes

hack/test-e2e-provider-local.sh Outdated Show resolved Hide resolved

ScheererJ requested changes Dec 5, 2023

View reviewed changes

Makefile Outdated Show resolved Hide resolved

gardener-robot added the needs/changes Needs (more) changes label Dec 5, 2023

DockToFuture reviewed Dec 5, 2023

View reviewed changes

ScheererJ requested changes Dec 5, 2023

View reviewed changes

.ci/pipeline_definitions Show resolved Hide resolved

ccwienk force-pushed the gcr-to-ar branch from 8327985 to 75dc415 Compare December 5, 2023 16:12

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 5, 2023

ccwienk force-pushed the gcr-to-ar branch from 75dc415 to 5f562b1 Compare December 5, 2023 16:38

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 5, 2023

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 5, 2023

run make generate

a86b082

ccwienk force-pushed the gcr-to-ar branch from 5f562b1 to a86b082 Compare December 5, 2023 16:41

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 5, 2023

ccwienk mentioned this pull request Dec 5, 2023

switch GCR -> Artifact-Registry gardener/gardener-extension-networking-calico#321

Merged

ScheererJ approved these changes Dec 6, 2023

View reviewed changes

.ci/pipeline_definitions Show resolved Hide resolved

gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Dec 6, 2023

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 6, 2023

ScheererJ merged commit f0f0894 into master Dec 6, 2023
8 checks passed

gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 6, 2023

ccwienk deleted the gcr-to-ar branch December 6, 2023 18:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch GCR -> Artifact-Registry #231

Switch GCR -> Artifact-Registry #231

ccwienk commented Nov 30, 2023

ccwienk commented Nov 30, 2023

ccwienk commented Nov 30, 2023

ccwienk commented Nov 30, 2023

ccwienk commented Dec 1, 2023

DockToFuture Dec 1, 2023

ccwienk Dec 1, 2023

DockToFuture Dec 5, 2023

ccwienk Dec 5, 2023

ScheererJ left a comment

Switch GCR -> Artifact-Registry #231

Switch GCR -> Artifact-Registry #231

Conversation

ccwienk commented Nov 30, 2023

ccwienk commented Nov 30, 2023

ccwienk commented Nov 30, 2023

ccwienk commented Nov 30, 2023

ccwienk commented Dec 1, 2023

DockToFuture Dec 1, 2023

Choose a reason for hiding this comment

ccwienk Dec 1, 2023

Choose a reason for hiding this comment

DockToFuture Dec 5, 2023

Choose a reason for hiding this comment

ccwienk Dec 5, 2023

Choose a reason for hiding this comment

ScheererJ left a comment

Choose a reason for hiding this comment