Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove install-requirement and use tools.mk #114

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Remove install-requirement and use tools.mk #114

merged 2 commits into from
Aug 1, 2022

Conversation

acumino
Copy link
Member

@acumino acumino commented Jul 26, 2022

How to categorize this PR?

/area networking
/kind enhancement

What this PR does / why we need it:
This PR adapts the tool concept according to gardener/gardener#6396 and removes the install-requirement script to install dependencies required for development on the fly and as needed.

Which issue(s) this PR fixes:
Part of gardener/gardener#6396

Special notes for your reviewer:

Release note:

NONE

@acumino acumino requested review from a team as code owners July 26, 2022 11:01
@gardener-robot gardener-robot added area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 26, 2022
@acumino acumino mentioned this pull request Jul 26, 2022
Closed
20 tasks
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 26, 2022
ScheererJ
ScheererJ requested changes Jul 26, 2022
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check why verify fails? It does not seem to find the binaries, which were installed by install-requirements in the past.

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Jul 26, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 26, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 26, 2022
@acumino acumino requested a review from ScheererJ July 26, 2022 15:08
ScheererJ
ScheererJ approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Jul 27, 2022
@ScheererJ ScheererJ merged commit d7d445a into gardener:master Aug 1, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@acumino @ScheererJ @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot