Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cilium to v1.12.0 #112

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Update cilium to v1.12.0 #112

merged 1 commit into from
Jul 25, 2022

Conversation

DockToFuture
Copy link
Member

How to categorize this PR?

/area networking
/kind enhancement

What this PR does / why we need it:
Update cilium to v1.12.0. For more information see the release notes.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Update cilium to `v1.12.0`.

@gardener-robot gardener-robot added area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jul 22, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 22, 2022
@DockToFuture DockToFuture force-pushed the update/cilium-v1.12.0 branch from 6ec2666 to 66dbf7d Compare July 22, 2022 11:00
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 22, 2022
@DockToFuture DockToFuture marked this pull request as ready for review July 22, 2022 11:01
@DockToFuture DockToFuture requested review from a team as code owners July 22, 2022 11:01
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 22, 2022
@DockToFuture DockToFuture force-pushed the update/cilium-v1.12.0 branch from 66dbf7d to 18ff387 Compare July 22, 2022 11:04
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 22, 2022
ScheererJ
ScheererJ previously approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Do we want to adapt our rp_filter init container to the "new" way of explicitly specifying what permissions are required? I would think that you can drop everything. It only needs to be able to write a file as root.

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Jul 22, 2022
@DockToFuture DockToFuture force-pushed the update/cilium-v1.12.0 branch from 18ff387 to 1a8bfa2 Compare July 25, 2022 06:38
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) reviewed/lgtm Has approval for merging labels Jul 25, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 25, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 25, 2022
@DockToFuture
Copy link
Member Author

/lgtm Do we want to adapt our rp_filter init container to the "new" way of explicitly specifying what permissions are required? I would think that you can drop everything. It only needs to be able to write a file as root.

Good proposal, adapted the rp_filter init container and verified that the change works.

ScheererJ
ScheererJ approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Jul 25, 2022
@DockToFuture DockToFuture merged commit 62c290b into gardener:master Jul 25, 2022
@DockToFuture DockToFuture deleted the update/cilium-v1.12.0 branch July 25, 2022 08:28
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DockToFuture @ScheererJ @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot