Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE if DNSEntry contains invalid domain name #387

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Aug 29, 2024

What this PR does / why we need it:
A bug is fixed causing a NPE if an invalid domain name is provided.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix NPE if DNSEntry contains invalid domain name

@MartinWeindel MartinWeindel requested a review from a team as a code owner August 29, 2024 11:13
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Aug 29, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 29, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 29, 2024
@MartinWeindel MartinWeindel merged commit 7641419 into master Aug 29, 2024
8 checks passed
@MartinWeindel MartinWeindel deleted the fix/panic-invalid-spec branch August 29, 2024 11:39
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 29, 2024
@MartinWeindel MartinWeindel changed the title Fix NPE if certificate contains invalid domain name Fix NPE if DNSEntry contains invalid domain name Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants