Merge dnsnames annotations from multiple DNSAnnotation objects #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
DNS "source" object, such as Service or Ingress, can be annotated in two ways: directly or through
DNSAnnotationresources.With the current behaviour, if multiple DNSAnnotation resources reference the same source object and use the same annotation key, only the value from the most recent DNSAnnotation resource will be used. This was implemented as a kind of conflict resolution, but is not optimal for the
dns.gardener.cloud/dnsnamesannotation.This proposed change ensures that all
dns.gardener.cloud/dnsnamesfrom all sources, particularly from multiple DNSAnnotation resources, are combined and applied. This means that instead of only considering the most recent DNSAnnotation, all of them will now be considered.Which issue(s) this PR fixes:
Fixes #351
Special notes for your reviewer:
Release note: