rfc2136 provider: expect base64 encoded TSIG key #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@Avarei Thank you for your contribution. |
gardener-robot
added
the
size/xs
|
Thank you @Avarei for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
|
@MartinWeindel fyi |
MartinWeindel
approved these changes
Dec 20, 2023
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
reviewed/ok-to-test
MartinWeindel
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
MartinWeindel
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Usually both tsig key tools generate, and dns servers are configured using the base64 encoded version of the TSIG Key.
This PR reduces complexity by removing base64 encoding during runtime, which removes the need to decode it for the Kubernetes Secret.
This also makes integration with external secret providers easier, as the binary data from the tsig key could be difficult to copy.
Which issue(s) this PR fixes:
Fixes #346
Special notes for your reviewer:
the diff in go.mod is due to running
go mod tidyRelease note: