Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to create DNSEntries for hosted zone base domain #316

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Allow to create DNSEntries for hosted zone base domain #316

merged 1 commit into from
Sep 29, 2023

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
Creating a DNSEntry for the base domain of a hosted zone is now allowed for all providers but azure-dns and azure-private-dns.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Creating a `DNSEntry` for the base domain of a hosted zone is now allowed for all providers but `azure-dns` and `azure-private-dns`.

@MartinWeindel MartinWeindel requested a review from a team as a code owner September 28, 2023 06:57
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Sep 28, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 28, 2023
@MartinWeindel MartinWeindel merged commit 32034df into master Sep 29, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 29, 2023
@MartinWeindel MartinWeindel deleted the enh/allow-base-domain branch September 29, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinWeindel @gardener-robot-ci-1 @gardener-robot