Don't cleanup entries belonging to provider of equivalent zone #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
gardener-robot
added
needs/review
MartinWeindel
force-pushed
the
fix-remote-data-race
branch
from
67e696a to
89507db
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
MartinWeindel
changed the title
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
MartinWeindel
force-pushed
the
fix-remote-data-race
branch
from
89507db to
4975e92
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
mandelsoft
approved these changes
May 30, 2022
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With introduction of a qualified zone id which includes the provider type, DNS entries are only created or updated during zone reconciliation of the zone identified by this qualified zone id.
But for deletion of DNS entries and cleanup of orphan records this separation did not work. After resyncing the zone state DNS records are deleted because the assignment to a provider type is not taken into consideration. If a hosted zone is both accessed directly and remotely ("central DNS proxy"), DNS entries belonging to one of them appear to be orphaned, but are belonging to the other one in fact.
This wrong behaviour is fixed here by excluding DNS entries belonging to such a "equivalent" zone on cleanup.
Which issue(s) this PR fixes:
Fixes #256
Special notes for your reviewer:
Release note: