Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add provider for Azure Private DNS #230

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Add provider for Azure Private DNS #230

merged 1 commit into from
Dec 7, 2021

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Nov 25, 2021 •
edited
Loading

What this PR does / why we need it:
Azure has a separate API for private DNS zones which cannot easily be covered with the existing azure-dns provider.
Therefore a new DNSProvider type azure-private-dns has been added to deal with private zones on Azure.

Which issue(s) this PR fixes:
Fixes #222

Special notes for your reviewer:

Release note:

Add provider named `azure-private-dns` for Azure Private DNS. In contrast to other infrastructures, public and private DNS zones handling is separated on Azure. For public DNS zone continue to use the provider named `azure-dns`.

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 25, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 25, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 25, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 25, 2021
@gardener-robot
Copy link

@mandelsoft You have pull request review open invite, please check

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 7, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 7, 2021
@MartinWeindel MartinWeindel merged commit 0eb9ab2 into master Dec 7, 2021
@MartinWeindel MartinWeindel deleted the azure-private branch December 7, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandelsoft mandelsoft mandelsoft approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Azure private DNS zones
5 participants
@MartinWeindel @gardener-robot @mandelsoft @gardener-robot-ci-1 @gardener-robot-ci-3