Allow domain labels starting with a digit #227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With PR #221 a stricter check of domain names and labels has been introduced.
Domain labels are now checked according to RFC 1035 which disallows labels longer than 63 characters and/or starting with a digit.
As we allow shoot cluster names starting with a digit character in Gardener, with the current default domain name schema no DNSEntries for such subdomains can be created anymore.
It also seems that this restriction from RFC 1035 is not enforced in the Internet, as you can even register domains starting with digits.
We have also not seen any DNS provider which rejects domain names containing domain labels starting with a digit.
Further research found that with RFC 1123, section 2.1, the restriction was relaxed:
Therefore this check is relaxed with this PR to allow domain labels starting with a digit again.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: