Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow domain labels starting with a digit #227

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Nov 12, 2021

What this PR does / why we need it:
With PR #221 a stricter check of domain names and labels has been introduced.
Domain labels are now checked according to RFC 1035 which disallows labels longer than 63 characters and/or starting with a digit.
As we allow shoot cluster names starting with a digit character in Gardener, with the current default domain name schema no DNSEntries for such subdomains can be created anymore.
It also seems that this restriction from RFC 1035 is not enforced in the Internet, as you can even register domains starting with digits.
We have also not seen any DNS provider which rejects domain names containing domain labels starting with a digit.

Further research found that with RFC 1123, section 2.1, the restriction was relaxed:

One aspect of host name syntax is hereby changed: the
restriction on the first character is relaxed to allow either a
letter or a digit. Host software MUST support this more liberal
syntax.

Therefore this check is relaxed with this PR to allow domain labels starting with a digit again.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Allow domain labels starting with a digit again (was disallowed with PR#221 in v0.11.0)

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 12, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 12, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 12, 2021
Copy link

@stoyanr stoyanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 12, 2021
@MartinWeindel MartinWeindel merged commit 6cb02a9 into master Nov 12, 2021
@MartinWeindel MartinWeindel deleted the relax-rfc1035 branch November 12, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants