Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing stop endpoint to stop running etcd-wrapper #31

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Introducing stop endpoint to stop running etcd-wrapper #31

merged 1 commit into from
Oct 7, 2024

Conversation

ishan16696
Copy link
Member

@ishan16696 ishan16696 commented Sep 30, 2024 •
edited
Loading

How to categorize this PR?
/kind enhancement

What this PR does / why we need it:

  • In order to achieve a restart of the etcd container inside the etcd member pod, this PR introduced a /stop endpoint in etcd-wrapper. Backup-restore can invoke this endpoint which will cause the container to exit and k8s to restart the container.

Which issue(s) this PR fixes:
Fixes #24

Special notes for your reviewer:

Release note:

Added a capability to stop the etcd-wrapper container by exposing an endpoint `/stop`.

@ishan16696 ishan16696 requested a review from a team as a code owner September 30, 2024 11:12
@gardener-robot gardener-robot added needs/review Needs review kind/enhancement Enhancement, improvement, extension size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Sep 30, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 30, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 30, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 30, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 4, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 4, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 4, 2024
This was referenced Oct 4, 2024
Merged
Closed
unmarshall
unmarshall reviewed Oct 7, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
unmarshall
unmarshall requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment, rest looks good.

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Oct 7, 2024
@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Oct 7, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 7, 2024
@ishan16696 ishan16696 changed the title Updated Makefile and introducing stop endpoint to stop etcd-wrapper Introducing stop endpoint to stop running etcd-wrapper Oct 7, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 7, 2024
unmarshall
unmarshall approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Oct 7, 2024
@gardener-robot gardener-robot removed needs/changes Needs (more) changes needs/review Needs review labels Oct 7, 2024
@unmarshall
Copy link
Contributor

I have tested the changes several times now.

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 7, 2024
@unmarshall unmarshall merged commit 022c3a0 into gardener:main Oct 7, 2024
8 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 7, 2024
@ishan16696 ishan16696 deleted the endpoint branch October 7, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall approved these changes

Assignees
No one assigned
Labels
kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Introduce HTTP endpoint to restart embedded etcd
6 participants
@ishan16696 @unmarshall @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot