Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor change in generating license headers #27

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Minor change in generating license headers #27

merged 1 commit into from
Mar 21, 2024

Conversation

shreyas-s-rao
Copy link
Contributor

How to categorize this PR?

/area usability
/kind enhancement

What this PR does / why we need it:
Remove the need for passing YEAR env var to make add-license-headers target.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/cc @unmarshall

Release note:

NONE

@shreyas-s-rao shreyas-s-rao added this to the v0.2.0 milestone Mar 15, 2024
@shreyas-s-rao shreyas-s-rao requested a review from a team as a code owner March 15, 2024 07:09
@gardener-robot gardener-robot added needs/review Needs review area/usability Usability related kind/enhancement Enhancement, improvement, extension size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 15, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 15, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 15, 2024
renormalize
renormalize approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@renormalize renormalize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes the command neater to use. Thanks!

@shreyas-s-rao shreyas-s-rao merged commit 9040608 into gardener:main Mar 21, 2024
8 checks passed
@shreyas-s-rao shreyas-s-rao deleted the fix/license-header branch March 21, 2024 05:53
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 21, 2024
shafeeqes pushed a commit to shafeeqes/etcd-wrapper that referenced this pull request Jul 10, 2024
@shreyas-s-rao @shafeeqes
Minor change in generating license headers (gardener#27)
85eceab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renormalize renormalize renormalize approved these changes

Assignees
No one assigned
Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@shreyas-s-rao @renormalize @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot