Remove deprecated API fields, CLI flag and annotation #990
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area usability
/kind cleanup task
What this PR does / why we need it:
This PR removes the following deprecated elements in etcd-druid:
Status.ServiceName
- not useful from a consumer perspectiveStatus.ClusterSize
- use the length ofStatus.Members
insteadStatus.UpdatedReplicas
- use conditionAllMembersUpdated
instead, introduced in Introduce new Etcd status conditionAllMembersUpdated
#987Status.LastError
- useStatus.LastErrors
instead, which allows population of multiple errors from the reconciliation flowignore-operation-annotation
- use CLI flagenable-etcd-spec-auto-reconcile
insteaddruid.gardener.cloud/ignore-reconciliation
- usedruid.gardener.cloud/suspend-etcd-spec-reconcile
annotation insteadPlease note that although field
Status.LabelSelector
has been marked as deprecated, it has not been removed, due to the fact that we might need to re-look at its use for vertical pod autoscaling via the/scale
subresource.Which issue(s) this PR fixes:
Fixes #801
Special notes for your reviewer:
/invite @unmarshall
/assign @unmarshall
Release note: