Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated API fields, CLI flag and annotation #990

Conversation

shreyas-s-rao
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao commented Jan 31, 2025

How to categorize this PR?

/area usability
/kind cleanup task

What this PR does / why we need it:
This PR removes the following deprecated elements in etcd-druid:

  • API field Status.ServiceName - not useful from a consumer perspective
  • API field Status.ClusterSize - use the length of Status.Members instead
  • API field Status.UpdatedReplicas - use condition AllMembersUpdated instead, introduced in Introduce new Etcd status condition AllMembersUpdated #987
  • API field Status.LastError - use Status.LastErrors instead, which allows population of multiple errors from the reconciliation flow
  • CLI flag ignore-operation-annotation - use CLI flag enable-etcd-spec-auto-reconcile instead
  • Annotation druid.gardener.cloud/ignore-reconciliation - use druid.gardener.cloud/suspend-etcd-spec-reconcile annotation instead

Please note that although field Status.LabelSelector has been marked as deprecated, it has not been removed, due to the fact that we might need to re-look at its use for vertical pod autoscaling via the /scale subresource.

Which issue(s) this PR fixes:
Fixes #801

Special notes for your reviewer:
/invite @unmarshall
/assign @unmarshall

Release note:

Remove deprecated status fields `ServiceName`, `ClusterSize`, `UpdatedReplicas` and `LastError`.
Remove deprecated CLI flag `ignore-operation-annotation`.
Remove support for deprecated annotation `druid.gardener.cloud/ignore-reconciliation`.

@shreyas-s-rao shreyas-s-rao added this to the v0.27.0 milestone Jan 31, 2025
@shreyas-s-rao shreyas-s-rao requested a review from a team as a code owner January 31, 2025 10:34
@gardener-robot gardener-robot added the needs/review Needs review label Jan 31, 2025
@gardener-robot gardener-robot added area/usability Usability related kind/cleanup Something that is not needed anymore and can be cleaned up kind/task General task labels Jan 31, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 31, 2025
@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Jan 31, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 31, 2025
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@shreyas-s-rao shreyas-s-rao merged commit 52e514f into gardener:master Feb 3, 2025
13 checks passed
@shreyas-s-rao shreyas-s-rao deleted the cleanup/remove-deprecated-status-fields branch February 3, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability Usability related kind/cleanup Something that is not needed anymore and can be cleaned up kind/task General task needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated fields from Etcd API
4 participants