Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed unneeded mkdocs branch from getting tracked for doc changes #912

Merged
merged 1 commit into from
Nov 11, 2024
Merged

removed unneeded mkdocs branch from getting tracked for doc changes #912

merged 1 commit into from
Nov 11, 2024

Conversation

unmarshall
Copy link
Contributor

How to categorize this PR?

/area documentation
/kind cleanup

What this PR does / why we need it:
As part of #909 mkdocs branch was used to do development. This was left over in the .github/workflows/publish-docs.yml as a tracked branch. This was done to help reviewers see the changes in a github page. Unfortunately this was left behind and not removed. This PR removes that tracked branch.

Which issue(s) this PR fixes:
Fixes #897

Release note:

none

@unmarshall unmarshall requested a review from a team as a code owner November 11, 2024 07:34
@gardener-robot gardener-robot added area/documentation Documentation related kind/cleanup Something that is not needed anymore and can be cleaned up needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 11, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 11, 2024
seshachalam-yv
seshachalam-yv approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 11, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 11, 2024
@unmarshall
Copy link
Contributor Author

/retest

1 similar comment
@unmarshall
Copy link
Contributor Author

/retest

@unmarshall unmarshall merged commit 4d73d54 into gardener:master Nov 11, 2024
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 11, 2024
@unmarshall unmarshall deleted the fixgithubaction branch December 12, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

@renormalize renormalize renormalize approved these changes

Assignees
No one assigned
Labels
area/documentation Documentation related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation improvement - Part 2
5 participants
@unmarshall @renormalize @seshachalam-yv @gardener-robot-ci-3 @gardener-robot